Bugzilla – Bug 348088
Support for latest Flash plugin
Last modified: 2008-02-20 07:28:04 UTC
AKA "Adobe sucks". The latest Flash player requires so-called "XEmbed browser protocol", and, somewhat forgetting to tell anyone, also requires Gtk2 eventloop support. Without either it simply does not work.
Created attachment 187237 [details] kdelibs3 patch This patch fixes QXEmbed in kdelibs. This patch should be final.
Created attachment 187238 [details] kdebase3 patch This is preliminary kdebase3 patch. It should be generally usable, but there are still few outstanding issues: - the Glib eventloop integration polls, it should be probably fixed not to - Flash crashes in XRemoteTimeout(), it seems to be a Flash bug, but given that Adobe apparently doesn't give a damn and it's pretty annoying, I guess a workaround is in order
Created attachment 187677 [details] kdebase3 patch The (hopefully) final version of the patch. I've left the Glib polling there as not being really necessary to fix and not worth it at this time. All the other problems should be fixed (well, that's a guess of course, since flashplayer is closed-source and the main reason for this is probably to prevent people getting sick from looking at parts of its code - there must be horrible things in it).
The patch should be tested on a 64bit system, but otherwise it should be ready.
I don't seem to be able to make it work on x86_64 and on i586 I get occasional rather random crashes (tested on http://wetter.rtl.de/deutschland/dt.php).
Created attachment 188041 [details] Example crash
Can't get it to work on KDE 3.5.8 on 32bit either. youtube.com is mostly blank in the places of videos.
Works fine on 32bit here, so there's nothing I can do unless you provide more details.
I am seeing Adobe Flash Player: gtk_clipboard_get(GDK_SELECTION_PRIMARY); failed. Trying to call gtk_init(0,0); on konsole, maybe its related.
No, that's normal. Are you sure you have both patches? If yes, please attach full debug output.
Sorry didn't notice the kdelibs patch, re-testing now.
Works fine after applying two patches, nice work!
Created attachment 188289 [details] kdelibs3 patch
Created attachment 188290 [details] kdebase3 patch With these patches even 64b with nspluginwrapper should work. Every Flash applet may be actually running twice because of a Flash bug, but hey, who cares. I have no idea about the random crashes from comments #6/#7, otherwise I'm not aware of any (serious) problem with the patches.
Last two patches look rather crashy here, I will revert to old patches and try a bit more.
Doesn't seem to work on x86_64 with the new patches either, and I have also the impression that it got more unstable on i586.
Last two patches made flash crash on 32bit, the good patches are : kdebase3 patch (65.89 KB, patch) 2007-12-14 09:31 MST, Lubos Lunak kdelibs3 patch (4.79 KB, patch) 2007-12-12 07:40 MST, Lubos Lunak Thanks, ismail
I suggest we release patches from comments #3 and #14 [*] together with the flash update unless I manage to provide better ones. [*] That is, the latest kdelibs3 patch (attachment #188289 [details]) and the older kdebase3 patch (attachment #187677 [details]).
Those work fine for me, kudos for this work, and shame on Adobe.
who is going to submit kdelibs3 packages?
Created attachment 188531 [details] kdelibs3 patch Ok, we're back at the original kdelibs3 patch (surprise, surprise). The other one shouldn't hurt though.
Created attachment 188532 [details] kdebase3 patch This one should even apply cleanly to our packages :).
Looks like attachment #188289 [details] as the kdelibs3 patch is a safer bet for now after all.
*** Bug 350515 has been marked as a duplicate of this bug. ***
*** Bug 350525 has been marked as a duplicate of this bug. ***
*** Bug 350545 has been marked as a duplicate of this bug. ***
*** Bug 350564 has been marked as a duplicate of this bug. ***
*** Bug 350656 has been marked as a duplicate of this bug. ***
*** Bug 350703 has been marked as a duplicate of this bug. ***
*** Bug 351877 has been marked as a duplicate of this bug. ***
we urgently need sles10 kdebase3 packages for this.
Did anyone contact Adobe and asked them whether they would like to avoid these kind of consequences in the future? Otherwise moonlight might really become an alternative if one wants to avoid Adobe's way of treating their KDE users.
Hmm. I tried the 10.1 updated packages too and I can confirm they don't work for me either. However, my own build of 3.5 branch, or the 3.5.1 release (i.e. 10.1 KDE), with latest qxembed and nsplugins, do work for me. So maybe one of our patches is interfering, or the package for 10.1 does not incorporate the fixes properly, or I did something wrong, or something :-/.
*** Bug 352873 has been marked as a duplicate of this bug. ***
Created attachment 190098 [details] gtk-qt-engine patch Patch for gtk-qt-engine for SL10.1/SLED10.
added to the package and submitted. gtk-qt-engine needs to be released for 10.1/sle10
is a gtk-qt-engine update necessary for 10.2 too?
and/or nld9? kdebase3 packages for SLES 10 and NLD 9 are still missing.
Are there plans to release the kdebase3/kdelib3 patches for openSuSE 10.2 as well? I haven't found them yet or am I missing something? Thank you.
Yes. However it is not curing all of the problems, on 64bit I only see Gray where there should be flash applets etc....
*** Bug 353581 has been marked as a duplicate of this bug. ***
Ok, 64bit fixed as well. For the record: The first commit for kdebase/nsplugins is r746927, for kdelibs/kdeui is r747606, and since the fixes break kcmshell in root mode (KDE#155001), also kdebase/kcontrol/kcontrol r757345 should be included.
Comment on attachment 188532 [details] kdebase3 patch Gtk-qt-engine patch remains, other are in SVN.
10.3,10.2,10.1,SLE10,NLD9 submitted (gtk-qt-engine, kdebase3, kdelibs3) SLE10 and 10.3 has been tested. NLD9 is untested.
released all but the NLD 9 fixes now.
so, all released now.